netdev - Re: [PATCH V2 01/22] net-next: mediatek: use mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160509120735.GR7972@lunn.ch>
Date:	Mon, 9 May 2016 14:07:35 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	John Crispin <john@...ozen.org>
Cc:	davem@...emloft.net, nbd@....name, netdev@...r.kernel.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH V2 01/22] net-next: mediatek: use mdiobus_free() in
 favour of kfree()

On Mon, May 09, 2016 at 12:03:53PM +0200, John Crispin wrote:
> The driver currently uses kfree() to clear the mii_bus. This is not the
> correct way to clear the memory and mdiobus_free() should be used instead.
> This patch fixes the two instances where this happens in the driver.
> 
> Reported-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: John Crispin <john@...ozen.org>

Thanks John

Reviewed-by: Andrew Lunn <andrew@...n.ch>

       Andrew