netdev - Re: [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160509120901.GS7972@lunn.ch>
Date:	Mon, 9 May 2016 14:09:01 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	John Crispin <john@...ozen.org>
Cc:	davem@...emloft.net, nbd@....name, netdev@...r.kernel.org,
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH V2 04/22] net-next: mediatek: properly handle RGMII modes

On Mon, May 09, 2016 at 12:03:56PM +0200, John Crispin wrote:
> If an external Gigabit PHY is connected to either of the MACs we need to
> be able to tell the PHY to use a delay. Not doing so will result in heavy
> packet loss and/or data corruption when using PHYs such as the IC+ IP1001.
> We tell the PHY which MII delay mode to use via the devictree.
> 
> The ethernet driver needs to be adapted to handle all 3 rgmii-*id modes
> in the same way as normal rgmii when setting up the MAC.
> 
> Signed-off-by: John Crispin <john@...ozen.org>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

	     Andrew