netdev - Re: [PATCH] net: phylib: fix interrupts re-enablement in phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160510.160105.1924401488013786863.davem@davemloft.net>
Date:	Tue, 10 May 2016 16:01:05 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	shh.xie@...il.com
Cc:	netdev@...r.kernel.org, f.fainelli@...il.com, Shaohui.Xie@....com
Subject: Re: [PATCH] net: phylib: fix interrupts re-enablement in phy_start

From: <shh.xie@...il.com>
Date: Tue, 10 May 2016 17:42:26 +0800

> From: Shaohui Xie <Shaohui.Xie@....com>
> 
> If phy was suspended and is starting, current driver always enable
> phy's interrupts, if phy works in polling, phy can raise unexpected
> interrupt which will not be handled, the interrupt will block system
> enter suspend again. So interrupts should only be re-enabled if phy
> works in interrupt.
> 
> Signed-off-by: Shaohui Xie <Shaohui.Xie@....com>

Applied.