netdev - Re: [PATCH net-next v2] ila: ipv6/ila: fix nlsize calculation for lwtunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 May 2016 16:01:11 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	tom@...bertland.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] ila: ipv6/ila: fix nlsize calculation for
 lwtunnel

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Tue, 10 May 2016 11:56:32 +0200

> From: Tom Herbert <tom@...bertland.com>
> 
> The handler 'ila_fill_encap_info' adds two attributes: ILA_ATTR_LOCATOR
> and ILA_ATTR_CSUM_MODE.
> 
> nla_total_size_64bit() must be use for ILA_ATTR_LOCATOR.
> 
> Also, do nla_put_u8 instead of nla_put_u64 for ILA_ATTR_CSUM_MODE.
> 
> Fixes: f13a82d87b21 ("ipv6: use nla_put_u64_64bit()")
> Fixes: 90bfe662db13 ("ila: add checksum neutral ILA translations")
> Reported-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>
> Signed-off-by: Tom Herbert <tom@...bertland.com>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Applied.