netdev - Re: [PATCH net-next 04/13] fou: Split out {fou,gue}_build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160512215522.1bc7ec75@halley>
Date:	Thu, 12 May 2016 21:55:22 +0300
From:	Shmulik Ladkani <shmulik.ladkani@...il.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<kernel-team@...com>
Subject: Re: [PATCH net-next 04/13] fou: Split out {fou,gue}_build_header

Hi Tom,

On Wed, 11 May 2016 09:47:24 -0700 Tom Herbert <tom@...bertland.com> wrote:
>  
> -int fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> -		     u8 *protocol, struct flowi4 *fl4);
> -int gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> -		     u8 *protocol, struct flowi4 *fl4);
> +int __fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> +		       u8 *protocol, __be16 *sport, int type);
> +int __gue_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
> +		       u8 *protocol, __be16 *sport, int type);

[snip]

> +EXPORT_SYMBOL(__fou_build_header);
> +
>  int fou_build_header(struct sk_buff *skb, struct ip_tunnel_encap *e,
>  		     u8 *protocol, struct flowi4 *fl4)

Assuming 'fou_build_header' is no longer part of the interface, why
not kill the existing EXPORT_SYMBOL(fou_build_header) and make it
static?

Same for 'gue_build_header'.

Regards,
Shmulik