netdev - Re: [PATCH net-next 05/13] fou: Add encap ops for IPv6 tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160512222628.271079a1@halley>
Date:	Thu, 12 May 2016 22:26:28 +0300
From:	Shmulik Ladkani <shmulik.ladkani@...il.com>
To:	Tom Herbert <tom@...bertland.com>
Cc:	<davem@...emloft.net>, <netdev@...r.kernel.org>,
	<kernel-team@...com>
Subject: Re: [PATCH net-next 05/13] fou: Add encap ops for IPv6 tunnels

Hi,

On Wed, 11 May 2016 09:47:25 -0700 Tom Herbert <tom@...bertland.com> wrote:
> This patch adds IP tunnel encapsulation operations for IPv6. This
> includes the infrastructure to add and delete operations. IPv6 variants
> of fou6_build_header and gue6_build_header are added in a new
> fou6 module. These encapsulation operations for fou and gue are
> automatically added when the fou6 module loads.

One small nit:

> +EXPORT_SYMBOL(fou6_build_header);

[snip]

> +EXPORT_SYMBOL(gue6_build_header);

As with previous patch, seems these needn't be exported. Am I missing
something here?

Reviewed-by: Shmulik Ladkani <shmulik.ladkani@...il.com>

Regards,
Shmulik