netdev - Re: [net-next PATCH] udp: Resolve NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpXWWbAKdkngMpE81Snmcam5cFY5JWt-tXSrHQVRU_nggA@mail.gmail.com>
Date:	Wed, 11 May 2016 21:29:34 -0700
From:	Cong Wang <xiyou.wangcong@...il.com>
To:	Alexander Duyck <aduyck@...antis.com>
Cc:	Linux Kernel Network Developers <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Alexander Duyck <alexander.duyck@...il.com>,
	Tom Herbert <tom@...bertland.com>
Subject: Re: [net-next PATCH] udp: Resolve NULL pointer dereference

On Wed, May 11, 2016 at 7:24 PM, Alexander Duyck <aduyck@...antis.com> wrote:
> While testing an OpenStack configuration using VXLANs I saw the following
> call trace:
...
>
> I believe the trace is pointing to the call to dev_net(dev) in
> udp4_lib_lookup_skb.  If I am not mistaken I believe it is possible for us
> to have skb_dst(skb)->dev be NULL.  So to resolve that I am adding a check
> for this case and skipping the assignment if such an event occurs.

Isn't in this tunneling case skb_dst() should be NULL?