netdev - Re: [PATCH net-next] net: vrf: protect changes to private data with rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160516.134746.1801114108978272123.davem@davemloft.net>
Date:	Mon, 16 May 2016 13:47:46 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: vrf: protect changes to private data
 with rcu

From: David Ahern <dsa@...ulusnetworks.com>
Date: Fri, 13 May 2016 12:23:45 -0700

> One cpu can be processing packets which includes using the cached route
> entries in the vrf device's private data and on another cpu the device
> gets deleted which releases the routes and sets the pointers in net_vrf
> to NULL. This results in datapath dereferencing a NULL pointer.
> 
> Fix by protecting access to dst's with rcu.
> 
> Fixes: 193125dbd8eb ("net: Introduce VRF device driver")
> Fixes: 35402e313663 ("net: Add IPv6 support to VRF device")
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

Applied.

> Dave: I can handle the backports to stable branches if you prefer.

Sure, I'd really appreciate that.