netdev - Re: [PATCH] stmmac: hardware TX COE doesn't work when force_thresh_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 May 2016 19:47:44 +0200
From:	Joachim Eastwood <manabian@...il.com>
To:	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
Cc:	netdev <netdev@...r.kernel.org>,
	"peppe.cavallaro" <peppe.cavallaro@...com>,
	alexandre.torgue@...com, David Miller <davem@...emloft.net>
Subject: Re: [PATCH] stmmac: hardware TX COE doesn't work when
 force_thresh_dma_mode is set

Hi Ezequiel,

On 16 May 2016 at 17:41, Ezequiel Garcia <ezequiel@...guardiasur.com.ar> wrote:
> Commit f748be531d70 ("stmmac: support new GMAC4") reverted a previous fix
> by mistake. This commit re-applies said fix:
>
>   commit dec2165ff38a99f937fe61875d102c6c8596c815
>   Author: Sonic Zhang <sonic.zhang@...log.com>
>   Date:   Thu Jan 22 14:55:57 2015 +0800
>   stmmac: hardware TX COE doesn't work when force_thresh_dma_mode is set
>
>   Clear the TX COE bit when force_thresh_dma_mode is set even hardware
>   dma capability says support.
>
>   Tested on BF609.
>
>   Signed-off-by: Sonic Zhang <sonic.zhang@...log.com>
>   Acked-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
>   Signed-off-by: David S. Miller <davem@...emloft.net>
>
> Tested on LPC4350 Hitex board.
>
> Fixes: f748be531d70 ("stmmac: support new GMAC4")
> Signed-off-by: Ezequiel Garcia <ezequiel@...guardiasur.com.ar>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index fd5ab7bfdb76..eac45d0c75e2 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -3131,7 +3131,12 @@ static int stmmac_hw_init(struct stmmac_priv *priv)
>                 priv->plat->enh_desc = priv->dma_cap.enh_desc;
>                 priv->plat->pmt = priv->dma_cap.pmt_remote_wake_up;
>
> -               priv->plat->tx_coe = priv->dma_cap.tx_coe;
> +               /* TXCOE doesn't work in thresh DMA mode */
> +               if (priv->plat->force_thresh_dma_mode)
> +                       priv->plat->tx_coe = 0;
> +               else
> +                       priv->plat->tx_coe = priv->dma_cap.tx_coe;
> +
>                 /* In case of GMAC4 rx_coe is from HW cap register. */
>                 priv->plat->rx_coe = priv->dma_cap.rx_coe;

Works for me on EA4357 board together with another patch to fix the DT
properties for DWMAC on lpc18xx.

Tested-by: Joachim Eastwood <manabian@...il.com>


regards,
Joachim Eastwood