netdev - Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160517.142224.1322153249705614542.davem@davemloft.net>
Date:	Tue, 17 May 2016 14:22:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	agraf@...e.de
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	michal.simek@...inx.com, dmurphy@...com, andrew@...n.ch
Subject: Re: [PATCH v2 2/2] phy dp83867: Make rgmii parameters optional

From: Alexander Graf <agraf@...e.de>
Date: Mon, 16 May 2016 20:52:43 +0200

> If you compile without OF_MDIO support in an RGMII configuration, we fail
> to configure the dp83867 phy today by writing garbage into its configuration
> registers.
> 
> On the other hand if you do compile with OF_MDIO and the phy gets loaded via
> device tree, you have to have the properties set in the device tree, otherwise
> we fail to load the driver and don't even attach the generic phy driver to
> the interface anymore.
> 
> To make things slightly more consistent, make the rgmii configuration properties
> optional and allow a user to omit them in their device tree.
> 
> Signed-off-by: Alexander Graf <agraf@...e.de>

Applied.