netdev - Re: [PATCH v2 1/2] phy dp83867: Fix compilation with CONFIG_OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160517.142219.1941942174765442762.davem@davemloft.net>
Date:	Tue, 17 May 2016 14:22:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	agraf@...e.de
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	michal.simek@...inx.com, dmurphy@...com, andrew@...n.ch
Subject: Re: [PATCH v2 1/2] phy dp83867: Fix compilation with
 CONFIG_OF_MDIO=m

From: Alexander Graf <agraf@...e.de>
Date: Mon, 16 May 2016 20:52:42 +0200

> When CONFIG_OF_MDIO is configured as module, the #define for it really
> is CONFIG_OF_MDIO_MODULE, not CONFIG_OF_MDIO. So if we are compiling it
> as module, the dp83867 doesn't see that OF_MDIO was selected and doesn't
> read the dt rgmii parameters.
> 
> The fix is simple: Use IS_ENABLED(). It checks for both - module as well
> as compiled in code.
> 
> Signed-off-by: Alexander Graf <agraf@...e.de>

Applied.