netdev - Re: [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160517.142238.1044761521251148537.davem@davemloft.net>
Date:	Tue, 17 May 2016 14:22:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ard.biesheuvel@...aro.org
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com,
	ricardo.salveti@...aro.org, leif.lindholm@...aro.org,
	graeme.gregory@...aro.org, amit.kucheria@...aro.org,
	nic_swsd@...ltek.com
Subject: Re: [PATCH v2] r8169: default to 64-bit DMA on recent PCIe chips

From: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Date: Sat, 14 May 2016 22:40:15 +0200

> The current logic around the 'use_dac' module parameter prevents the
> r81969 driver from being loadable on 64-bit systems without any RAM
> below 4 GB when the parameter is left at its default value.
> 
> So introduce a new default value -1 which indicates that 64-bit DMA
> should be enabled on sufficiently recent PCIe chips, i.e., versions
> RTL_GIGA_MAC_VER_18 or later. Explicit param values of 0 or 1 retain
> the existing behavior of unconditionally enabling/disabling 64-bit DMA
> on 64-bit architectures (i.e., regardless of the type and version of the
> chip)
> 
> Since PCIe chips do not need to CPlusCmd Dual Address Cycle to be set,
> make that conditional on the device type as well.
> 
> Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@...aro.org>

Applied, let's see what happens...