netdev - Re: [PATCH net,stable v2] net: cdc_ncm: update datagram size after changing mtu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160520.193202.1451120008648712255.davem@davemloft.net>
Date:	Fri, 20 May 2016 19:32:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	robert.dobrowolski@...ux.intel.com
Cc:	linux-usb@...r.kernel.org, stable@...r.kernel.org,
	oliver@...kum.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, rafal.f.redzimski@...el.com
Subject: Re: [PATCH net,stable v2] net: cdc_ncm: update datagram size after
 changing mtu

From: Robert Dobrowolski <robert.dobrowolski@...ux.intel.com>
Date: Thu, 19 May 2016 11:56:09 +0200

> From: Rafal Redzimski <rafal.f.redzimski@...el.com>
> 
> Current implementation updates the mtu size and notify cdc_ncm
> device using USB_CDC_SET_MAX_DATAGRAM_SIZE request about datagram
> size change instead of changing rx_urb_size.
> 
> Whenever mtu is being changed, datagram size should also be
> updated. Also updating maxmtu formula so it takes max_datagram_size with
> use of cdc_ncm_max_dgram_size() and not ctx.
> 
> Signed-off-by: Robert Dobrowolski <robert.dobrowolski@...ux.intel.com>
> Signed-off-by: Rafal Redzimski <rafal.f.redzimski@...el.com>

Appied, thanks.