netdev - Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff not found (regression from rc7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <573EC33D.2010209@arm.com>
Date:	Fri, 20 May 2016 08:56:45 +0100
From:	Marc Zyngier <marc.zyngier@....com>
To:	Andre Heider <a.heider@...il.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Alexandre Torgue <alexandre.torgue@...com>
Cc:	Bert Lindner <bert@....net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Robin Murphy <robin.murphy@....com>,
	Andreas Färber <afaerber@...e.de>,
	linux-arm-kernel@...ts.infradead.org,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	linux-sunxi@...glegroups.com
Subject: Re: 4.5.0 on sun7i-a20-olinuxino-lime2: libphy: PHY stmmac-0:ffffffff
 not found (regression from rc7)

On 20/05/16 06:44, Andre Heider wrote:
> Giuseppe, Alexandre, et al.,
> 
> On Thu, Mar 17, 2016 at 8:52 AM, Marc Zyngier <marc.zyngier@....com> wrote:
>> On Thu, 17 Mar 2016 00:56:40 +0100
>> Bert Lindner <bert@....net> wrote:
>>> On 2016-03-16 18:42, Marc Zyngier wrote:
>>>> On 16/03/16 15:10, Bert Lindner wrote:
>>>>> On 2016-03-16 14:10, Andreas Färber wrote:
>>>>>> Am 16.03.2016 um 13:09 schrieb Robin Murphy:
>>>>>>> On 16/03/16 11:39, Marc Zyngier wrote:
>>>>>>>> On 16/03/16 11:19, Bert Lindner wrote:
> ...
>>>>>>>>> For the board sun7i-a20-olinuxino-lime2, there seems to be a problem
>>>>>>>>> with the eth0 PHY in mainline kernel 4.5.0 that developed since
>>>>>>>>> 4.5.0-rc7. Ethernet does not work, although eth0 is reported:
> ...
>>>>>>>>> [    9.767125] NET: Registered protocol family 10
>>>>>>>>> [   10.357405] libphy: PHY stmmac-0:ffffffff not found
>>>>>>>>> [   10.362382] eth0: Could not attach to PHY
>>>>>>>>> [   10.366557] stmmac_open: Cannot attach to PHY (error: -19)
> ...
>>>>>> v4 fixes for 4.5 are here:
>>>>>>
>>>>>> https://patchwork.ozlabs.org/patch/598195/ (revert)
>>>>>> https://patchwork.ozlabs.org/patch/598196/
> ...
>>>> Good to know, thanks. Could you also give the potential fix a go (as
>>>> mentioned by Andreas)? Just to make sure that whatever gets merged next
>>>> will actually fix the issue.
>>>
>>> Yes sure, it took a while because I had to travel. Confirmed, the
>>> v4-for-4.5 fix works well for me, on sun7i-a20-olinuxino-lime2:
>>>
>>> root@...e2-079f:~# cat /proc/version
>>> Linux version 4.5.0-598195-598196-v4 (root@...e2-079f) (gcc version
>>> 4.9.1 (Ubuntu/Linaro 4.9.1-16ubuntu6) ) #1 SMP Wed Mar 16 16:44:22 UTC 2016
>>>
>>> dmesg:
>>> [    8.245273] NET: Registered protocol family 10
>>> [    9.297406]  RX IPC Checksum Offload disabled
>>> [    9.297460]  No MAC Management Counters available
>>> [    9.297951] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready
>>> [   16.285658] sun7i-dwmac 1c50000.ethernet eth0: Link is Up -
>>> 1Gbps/Full - flow control rx/tx
>>> [   16.285798] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready
>>>
>>> The board is connected to my laptop rather than to a switch, so that
>>> might be where the flow control message comes from (not sure). Anyway
>>> ethernet works.
>>
>> Cool, many thanks for taking the time to test and report.
>>
>> Hopefully Giuseppe will get this merged quickly enough in mainline, and
>> it should then trickle into a 4.5-stable release (cc-ing stable on
>> these patches would probably be a good idea, BTW).
> 
> stmmac is broken on at least Lime2, BananaPi and Cubieboard2 since
> v4.5 [0], including all five stable releases :(

All the A20 platforms are dead, actually.

> The v4.5 patches quoted above are already +4 weeks old, could we
> please get them into stable?

For that, the maintainer would have needed to CC stable, which he
didn't. I'd expect someone who cares to send these patches to stable.
It'd be better if the maintainer would do it himself though.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...