netdev - Re: [PATCHv3] phy: fix crash in fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160520.105032.1917286986199018607.davem@davemloft.net>
Date:	Fri, 20 May 2016 10:50:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rabin.vincent@...s.com
Cc:	andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
	rabinv@...s.com
Subject: Re: [PATCHv3] phy: fix crash in fixed_phy_add()

From: Rabin Vincent <rabin.vincent@...s.com>
Date: Wed, 18 May 2016 12:47:31 +0200

> From: Rabin Vincent <rabinv@...s.com>
> 
> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"),
> platforms which call fixed_phy_add() before fixed_mdio_bus_init() is
> called (for example, because the platform code and the fixed_phy driver
> use the same initcall level) crash in fixed_phy_add() since the
> ->mii_bus is not allocated.
> 
> Also since e7f4dc3536a, these interrupts are initalized to polling by
> default.  The few (old) platforms which directly use fixed_phy_add()
> from their platform code all pass PHY_POLL for the irq argument, so we
> can keep these platforms not crashing by simply not attempting to set
> the irq if PHY_POLL is passed.
> 
> Also, even if problems have not been reported on more modern platforms
> which used fixed_phy_register() from drivers' probe functions, we return
> -EPROBE_DEFER if the MDIO bus is not yet registered so that the probe is
> retried later.
> 
> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
> Signed-off-by: Rabin Vincent <rabinv@...s.com>
> ---
> v3: One more suggestion from Andrew: check mii bus state

Applied, thanks.