netdev - Re: [PATCH net-next] xen-netback: correct length checks on hash copy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160520.105122.1212595607418214946.davem@davemloft.net>
Date:	Fri, 20 May 2016 10:51:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	paul.durrant@...rix.com
Cc:	xen-devel@...ts.xenproject.org, netdev@...r.kernel.org,
	wei.liu2@...rix.com
Subject: Re: [PATCH net-next] xen-netback: correct length checks on hash
 copy_ops

From: Paul Durrant <paul.durrant@...rix.com>
Date: Wed, 18 May 2016 08:53:01 +0100

> The length checks on the grant table copy_ops for setting hash key and
> hash mapping are checking the local 'len' value which is correct in
> the case of the former but not the latter. This was picked up by
> static analysis checks.
> 
> This patch replaces checks of 'len' with 'copy_op.len' in both cases
> to correct the incorrect check, keep the two checks consistent, and to
> make it clear what the checks are for.
> 
> Signed-off-by: Paul Durrant <paul.durrant@...rix.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.