netdev - Re: [PATCH] net/atm: sk_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160523.135136.1639061056251132017.davem@davemloft.net>
Date:	Mon, 23 May 2016 13:51:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	stefanha@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net/atm: sk_err_soft must be positive

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Wed, 18 May 2016 17:42:13 -0700

> The sk_err and sk_err_soft fields are positive errno values and
> userspace applications rely on this when using getsockopt(SO_ERROR).
> 
> ATM code places an -errno into sk_err_soft in sigd_send() and returns it
> from svc_addparty()/svc_dropparty().
> 
> Although I am not familiar with ATM code I came to this conclusion
> because:
 ...
> This patch ensures that sk_err_soft is always a positive errno.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>
> ---
> This patch is untested and potentially affects the getsockopt(SO_ERROR) ABI for
> a specific case in ATM.  I leave it to the maintainer to decide whether this
> inconsistency should be fixed or not.

This looks fine, applied, thanks.