netdev - Re: [PATCH] Accept user specified MTU value when create new vxlan link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20160526.123436.1240760291714449988.davem@davemloft.net>
Date:	Thu, 26 May 2016 12:34:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	oc@...ify.com
Cc:	netdev@...r.kernel.org, trivial@...nel.org
Subject: Re: [PATCH] Accept user specified MTU value when create new vxlan
 link

From: Chen Haiquan <oc@...ify.com>
Date: Thu, 26 May 2016 17:09:01 +0800

> Fixes: 0dfbdf4102b9303d3ddf2177c0220098ff99f6de
> (vxlan: Factor out device configuration) which missed MTU value specified
> by user when create new vxlan link.
> 
> Signed-off-by:  Chen Haiquan <oc@...ify.com>

This is not a properly formatted patch submission.

First of all, your Subject line should have a proper subsystem prefix
specified.  That way people who scan the GIT shortlog can tell where
your change is taking place by scanning the beginning of every commit
header line.

	[PATCH] vxlan: Use specified MTU value when creating new link.

Second, your Fixes tag is not the place where you explain the problem
and how you are fixing it.

You put that in the commit message proper, then you give the Fixes:
tag.

Have you looked at how other people format their commit messages?
Have you seen anyone else do things the way you have done so here?
Always mimick other patch submitters, and learn by example.  If you
still can't figure out how to format something properly, ask the
list.

Thanks.