netdev - Re: [PATCH net 4/4] net/mlx4_en: get rid of private net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160526.123541.8425919777831825.davem@davemloft.net>
Date:	Thu, 26 May 2016 12:35:41 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ttoukan.linux@...il.com
Cc:	edumazet@...gle.com, netdev@...r.kernel.org, willemb@...gle.com,
	eugenia@...lanox.com, eric.dumazet@...il.com
Subject: Re: [PATCH net 4/4] net/mlx4_en: get rid of private
 net_device_stats

From: Tariq Toukan <ttoukan.linux@...il.com>
Date: Thu, 26 May 2016 12:38:58 +0300

> I am aware that clearing the stats structure might be redundant today,
> as the function is called only within mlx4_en_open, but we might want
> to call the function in other flows in the future.

You really should not arbitrarily clear the statistics, a down/up is not
supposed to rest them, for example.