netdev - Re: [PATCH net 4/4] net/mlx4_en: get rid of private net_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160526.123849.1592401154314458544.davem@davemloft.net>
Date:	Thu, 26 May 2016 12:38:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ttoukan.linux@...il.com, edumazet@...gle.com,
	netdev@...r.kernel.org, willemb@...gle.com, eugenia@...lanox.com
Subject: Re: [PATCH net 4/4] net/mlx4_en: get rid of private
 net_device_stats

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 26 May 2016 05:54:10 -0700

> These stats being computed using deltas, this can not work as is.
> 
> I believe the rule is to not clear the netdev stats at open()

+1

Any driver clearing stats at open is broken and will break many,
many, networking tools.  And bonding too.