netdev - Re: [PATCH v2 05/10] nl80211: Fix checkpatch.pl NULL comparison warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgVq-QcoofQtnOG19Xh=yK61N1oVuq2XSNyjJA65kL1wtQ@mail.gmail.com>
Date:	Mon, 30 May 2016 15:22:25 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Kirtika Ruchandani <kirtika.ruchandani@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Tina Ruchandani <ruchandani.tina@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 05/10] nl80211: Fix checkpatch.pl NULL comparison warning

Hi All,

On Mon, May 30, 2016 at 12:52 PM, Kirtika Ruchandani
<kirtika.ruchandani@...il.com> wrote:
> This patch fixes the warning - "comparison to NULL (foo == NULL)
> could be written as (!foo)"
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchandani@...il.com>

Looks right to me.

Reviewed-by: Julian Calaby <julian.calaby@...il.com>

Thanks,

Julian Calaby

> ---
>  net/wireless/nl80211.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 945405d..11cbf0b 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -928,7 +928,7 @@ static struct ieee80211_channel *nl80211_get_valid_chan(struct wiphy *wiphy,
>  {
>         struct ieee80211_channel *chan;
>
> -       if (tb == NULL)
> +       if (!tb)
>                 return NULL;
>         chan = ieee80211_get_channel(wiphy, nla_get_u32(tb));
>         if (!chan || chan->flags & IEEE80211_CHAN_DISABLED)
> @@ -8575,7 +8575,7 @@ static int nl80211_set_tx_bitrate_mask(struct sk_buff *skb,
>                 if (band < 0 || band >= NUM_NL80211_BANDS)
>                         return -EINVAL;
>                 sband = rdev->wiphy.bands[band];
> -               if (sband == NULL)
> +               if (!sband)
>                         return -EINVAL;
>                 err = nla_parse(tb, NL80211_TXRATE_MAX, nla_data(tx_rates),
>                                 nla_len(tx_rates), nl80211_txattr_policy);
> --
> 2.8.0.rc3.226.g39d4020
>



-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/