netdev - Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGRGNgWYuEVnF7OG4GKJrnNNkn8DWaAor=ebbiwRbTZBP8qn5Q@mail.gmail.com>
Date:	Mon, 30 May 2016 15:25:50 +1000
From:	Julian Calaby <julian.calaby@...il.com>
To:	Kirtika Ruchandani <kirtika.ruchandani@...il.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	Tina Ruchandani <ruchandani.tina@...il.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 06/10] nl80211: Various checkpatch.pl spacing fixes

Hi All,

On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani
<kirtika.ruchandani@...il.com> wrote:
> This patch fixes the following spacing issues reported
> by checkpatch.pl -
> - space preferred around that <operator>
> - no space needed after cast.
> - Alignment should match open parenthesis
> - suspect code indent for conditional statements
> - Statements should start on a tabstop
>
> This patch also contains two hunks to fix 'line over 80 characters',
> that are spacing related.
> All other instances of that warning have been ignored.
>
> Signed-off-by: Kirtika Ruchandani <kirtika.ruchandani@...il.com>

Looks right to me except for one minor point:

> ---
>  net/wireless/nl80211.c | 103 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 54 insertions(+), 49 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 11cbf0b..ad7cdce 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -1735,8 +1735,9 @@ static int nl80211_send_wiphy(struct cfg80211_registered_device *rdev,
>                                rdev->wiphy.max_num_csa_counters))
>                         goto nla_put_failure;
>
> -               if (rdev->wiphy.regulatory_flags & REGULATORY_WIPHY_SELF_MANAGED &&
> -                   nla_put_flag(msg, NL80211_ATTR_WIPHY_SELF_MANAGED_REG))
> +               if ((rdev->wiphy.regulatory_flags &
> +                    REGULATORY_WIPHY_SELF_MANAGED) &&
> +                    nla_put_flag(msg, NL80211_ATTR_WIPHY_SELF_MANAGED_REG))

Adding the brackets around the & expression doesn't look spacing
related to me. What's the exact warning this is fixing?

>                         goto nla_put_failure;
>
>                 if (nla_put(msg, NL80211_ATTR_EXT_FEATURES,

Thanks,

-- 
Julian Calaby

Email: julian.calaby@...il.com
Profile: http://www.google.com/profiles/julian.calaby/