lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGRGNgX0B-Px5r4-Ad7f4B3Q6UrY=aGLn9g4Xd+=kJoXWt-_dQ@mail.gmail.com> Date: Mon, 30 May 2016 15:30:59 +1000 From: Julian Calaby <julian.calaby@...il.com> To: Kirtika Ruchandani <kirtika.ruchandani@...il.com> Cc: Johannes Berg <johannes@...solutions.net>, linux-wireless <linux-wireless@...r.kernel.org>, Tina Ruchandani <ruchandani.tina@...il.com>, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH v2 07/10] nl80211: Avoid multiple assignments on same line Hi All, On Mon, May 30, 2016 at 12:53 PM, Kirtika Ruchandani <kirtika.ruchandani@...il.com> wrote: > This patch fixes the checkpatch.pl warning "multiple assignments > should be avoided." > > Signed-off-by: Kirtika Ruchandani <kirtika.ruchandani@...il.com> I'm not sure I agree with checkpatch here, but this looks right to me. Reviewed-by: Julian Calaby <julian.calaby@...il.com> Thanks, Julian Calaby > --- > net/wireless/nl80211.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > index ad7cdce..6f8e2a7 100644 > --- a/net/wireless/nl80211.c > +++ b/net/wireless/nl80211.c > @@ -2603,7 +2603,8 @@ static int nl80211_set_interface(struct sk_buff *skb, struct genl_info *info) > > memset(¶ms, 0, sizeof(params)); > > - otype = ntype = dev->ieee80211_ptr->iftype; > + otype = dev->ieee80211_ptr->iftype; > + ntype = dev->ieee80211_ptr->iftype; > > if (info->attrs[NL80211_ATTR_IFTYPE]) { > ntype = nla_get_u32(info->attrs[NL80211_ATTR_IFTYPE]); > -- > 2.8.0.rc3.226.g39d4020 > -- Julian Calaby Email: julian.calaby@...il.com Profile: http://www.google.com/profiles/julian.calaby/
Powered by blists - more mailing lists