netdev - Re: [PATCH] stmmac: do not sleep in atomic context for mdio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160602.121245.1302730459604436490.davem@davemloft.net>
Date:	Thu, 02 Jun 2016 12:12:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vpalatin@...omium.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	alexandre.torgue@...com, peppe.cavallaro@...com
Subject: Re: [PATCH] stmmac: do not sleep in atomic context for mdio_reset

From: Vincent Palatin <vpalatin@...omium.org>
Date: Wed,  1 Jun 2016 08:53:48 -0700

> stmmac_mdio_reset() has been updated to use msleep rather udelay
> (as some PHY requires a one second delay there).
> It called from stmmac_resume() within the spin_lock_irqsave block
> atomic context triggering 'scheduling while atomic'.
> 
> The stmmac_priv lock usage is not fully documented, but it seems
> to protect the access to the MAC registers / DMA structures rather
> than the MDIO bus or the PHY (which have separate locking),
> so we can push the spin_lock after the stmmac_mdio_reset call.
> 
> Signed-off-by: Vincent Palatin <vpalatin@...omium.org>

Applied, thanks.