lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20160602.121541.1591890175711948513.davem@davemloft.net> Date: Thu, 02 Jun 2016 12:15:41 -0700 (PDT) From: David Miller <davem@...emloft.net> To: bhaktipriya96@...il.com Cc: akinobu.mita@...il.com, a@...table.cc, felipe.balbi@...ux.intel.com, fw@...len.de, tj@...nel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] net: ethernet: wiznet: Remove create_workqueue From: Bhaktipriya Shridhar <bhaktipriya96@...il.com> Date: Wed, 1 Jun 2016 23:29:15 +0530 > alloc_workqueue replaces deprecated create_workqueue(). > > A dedicated workqueue has been used since the workitems are involved > in normal device operation. Workitems &priv->rx_work and &priv->tx_work, > map to w5100_rx_work and w5100_tx_work respectively and are involved in > receiving and transmitting packets. Forward progress under > memory pressure is a requirement here. > > create_workqueue has been replaced with alloc_workqueue with max_active > as 0 since there is no need for throttling the number of active work > items. > > Since the driver may be used in memory reclaim path, > WQ_MEM_RECLAIM has been set to guarantee forward progress. > > flush_workqueue is unnecessary since destroy_workqueue() itself calls > drain_workqueue() which flushes repeatedly till the workqueue > becomes empty. Hence the call to flush_workqueue() has been dropped. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@...il.com> Applied to net-next, thanks.
Powered by blists - more mailing lists