netdev - Re: [PATCH] soreuseport: add compat case for setsockopt SO_ATTACH_REUSEPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cec14e5-2950-be26-1ffa-8d604bdb2fb5@cogentembedded.com>
Date:	Fri, 3 Jun 2016 21:11:24 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Helge Deller <deller@....de>, Craig Gallek <kraig@...gle.com>,
	Alexei Starovoitov <ast@...nel.org>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Cc:	linux-parisc@...r.kernel.org
Subject: Re: [PATCH] soreuseport: add compat case for setsockopt
 SO_ATTACH_REUSEPORT_CBPF

Hello.

On 06/03/2016 08:18 PM, Helge Deller wrote:

> Commit 538950a ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")

    At least 12 digits must be specified for SHA1. checkpatch.pl should've 
caught this.

> missed to add the compat case for the SO_ATTACH_REUSEPORT_CBPF
> setsockoption() option.
>
> Since both SO_ATTACH_FILTER and SO_ATTACH_REUSEPORT_CBPF use a struct
> sock_fprog let's combine the handling of both.
>
> Signed-off-by: Helge Deller <deller@....de>
>
> diff --git a/net/compat.c b/net/compat.c
> index 5cfd26a..7e2aac9 100644
> --- a/net/compat.c
> +++ b/net/compat.c
> @@ -309,7 +309,7 @@ void scm_detach_fds_compat(struct msghdr *kmsg, struct scm_cookie *scm)
>  	__scm_destroy(scm);
>  }
>
> -static int do_set_attach_filter(struct socket *sock, int level, int optname,
> +static int do_sockopt_fix_sock_fprog(struct socket *sock, int level, int optname,
>  				char __user *optval, unsigned int optlen)

    You need to realign this line now.

[...]

WBR, Sergei