netdev - Re: [PATCH net-next 0/4] net: dsa: bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160609.221324.1107821306644656550.davem@davemloft.net>
Date:	Thu, 09 Jun 2016 22:13:24 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org, andrew@...n.ch,
	vivien.didelot@...oirfairelinux.com, jiri@...lanox.com,
	idosch@...lanox.com
Subject: Re: [PATCH net-next 0/4] net: dsa: bcm_sf2: add VLAN support

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu,  9 Jun 2016 17:42:04 -0700

> This is long overdue, finally add support for VLANs in the Broadcom Starfigther
> 2 switch driver.
> 
> There are a few things that make us differ from e.g; mv88e6xxx.c:
> 
> - we keep a software cache of which VLANs are enabled and which are not to
>   dramatically speed up the VLAN dump operation, we do not have any HW operation
>   which would only return the list of valid VLAN entries, they would have to be
>   all queried one by one, with 4K vlans, this takes a while
> 
> - the default behavior is equivalent to setting VLAN filtering to 1, still working
>   on implementing a proper port_vlan_filtering callback, but I figured the most
>   conservative behavior is probably okay anyway
> 
> - without enabling VLANs, the default behavior is to receive any 802.1q frames
>   (per the DSA documentation), however, once we start enabling VLAN support, if
>   an interface leaves the bridge, we still want it to receive all 802.1q frames
>   so we utiliez the "Join all VLAN" feature of the switch to perform that

Series applied, thanks Florian.

I wonder how many other switch chip drivers could benefit from the
VLAN sw caching thing.