netdev - Re: [PATCH net-next 4/4] net: dsa: bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160610120046.GB2338@lunn.ch>
Date:	Fri, 10 Jun 2016 14:00:46 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	vivien.didelot@...oirfairelinux.com, jiri@...lanox.com,
	idosch@...lanox.com
Subject: Re: [PATCH net-next 4/4] net: dsa: bcm_sf2: Add VLAN support

> @@ -148,6 +155,9 @@ struct bcm_sf2_priv {
>  	struct device_node		*master_mii_dn;
>  	struct mii_bus			*slave_mii_bus;
>  	struct mii_bus			*master_mii_bus;
> +
> +	/* Cache of programmed VLANs */
> +	struct bcm_sf2_vlan		vlans[VLAN_N_VID];

Hi Florian

This is a 16Kbyte array. So i assume the whole priv structure needs 5
pages. Have you had any trouble allocating this much memory,
particularly once it has been used for a while and fragmented?

I just wondered if it might be better to use vmalloc() for the
vlans.

	Andrew