netdev - Re: [PATCH net-next 0/4] net_sched: remove qdisc_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160610.233707.1963309173677043993.davem@davemloft.net>
Date:	Fri, 10 Jun 2016 23:37:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	edumazet@...gle.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 0/4] net_sched: remove qdisc_is_throttled()

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 10 Jun 2016 16:41:35 -0700

> HTB, CBQ and HFSC pay a very high cost updating the qdisc 'throttled'
> status that nothing but CBQ seems to use.
> 
> CBQ usage is flaky anyway, since no qdisc ->enqueue() updates the
> 'throttled' qdisc status.
> 
> This looks like some 'optimization' that actually cost more than code
> without the optimization, and might cause latency issues with CBQ.
> 
> In my tests, I could achieve a 8 % performance increase in TCP_RR
> workload through HTB qdisc, in presence of throttled classes,
> and 5 % without throttled classes.

Series applied, thanks.