netdev - Re: [PATCH next] sched: remove NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160611.000047.2179423929953796335.davem@davemloft.net>
Date:	Sat, 11 Jun 2016 00:00:47 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fw@...len.de
Cc:	netdev@...r.kernel.org, a@...table.cc, sw@...onwunderlich.de,
	mareklindner@...mailbox.ch, sven@...fation.org
Subject: Re: [PATCH next] sched: remove NET_XMIT_POLICED

From: David Miller <davem@...emloft.net>
Date: Fri, 10 Jun 2016 23:31:37 -0700 (PDT)

> From: Florian Westphal <fw@...len.de>
> Date: Fri, 10 Jun 2016 14:21:29 +0200
> 
>> ... its not returned anywhere.
>> 
>> BATMAN uses it as an intermediate return value to signal
>> forwarding vs. buffering, but it will not return POLICED to
>> callers outside of BATMAN.
>> 
>> sch_atm uses it, but on closer look its not returned either since
>> the initialisation is always overwritten with qdisc_enqueue() retval.
>> 
>> Signed-off-by: Florian Westphal <fw@...len.de>
> 
> Applied, thanks.

I have to revert this, the sch_atm.c change is wrong.

NET_XMIT_POLICED is the default value of 'ret' which can be used
if we branch to 'drop'.  So now GCC says that 'ret' might be used
uninitialized.

So it is actually used, and reported by sch_atm when TC_ACT_SHOT
classifications occur.