netdev - Re: [PATCH next] sched: remove NET_XMIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160611090605.GA3669@breakpoint.cc>
Date:	Sat, 11 Jun 2016 11:06:05 +0200
From:	Florian Westphal <fw@...len.de>
To:	David Miller <davem@...emloft.net>
Cc:	fw@...len.de, netdev@...r.kernel.org, a@...table.cc,
	sw@...onwunderlich.de, mareklindner@...mailbox.ch,
	sven@...fation.org
Subject: Re: [PATCH next] sched: remove NET_XMIT_POLICED

David Miller <davem@...emloft.net> wrote:
> I have to revert this, the sch_atm.c change is wrong.
> 
> NET_XMIT_POLICED is the default value of 'ret' which can be used
> if we branch to 'drop'.  So now GCC says that 'ret' might be used
> uninitialized.

Hmpf, seems I need to update gcc :-|

> So it is actually used, and reported by sch_atm when TC_ACT_SHOT
> classifications occur.

I'll resubmit a v2 changing initializer to NET_XMIT_DROP.