netdev - Re: [PATCH net-next] tcp: return sizeof tcp_dctcp_info in dctcp_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575ED59D.2000908@iogearbox.net>
Date:	Mon, 13 Jun 2016 17:47:41 +0200
From:	Daniel Borkmann <daniel@...earbox.net>
To:	Neal Cardwell <ncardwell@...gle.com>,
	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, Soheil Hassas Yeganeh <soheil@...gle.com>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next] tcp: return sizeof tcp_dctcp_info in dctcp_get_info()

On 06/13/2016 05:20 PM, Neal Cardwell wrote:
> Make sure that dctcp_get_info() returns only the size of the
> info->dctcp struct that it zeroes out and fills in. Previously it had
> been returning the size of the enclosing tcp_cc_info union,
> sizeof(*info).  There is no problem yet, but that union that may one
> day be larger than struct tcp_dctcp_info, in which case the
> TCP_CC_INFO code might accidentally copy uninitialized bytes from the
> stack.
>
> Signed-off-by: Neal Cardwell <ncardwell@...gle.com>
> Signed-off-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Acked-by: Daniel Borkmann <daniel@...earbox.net>