netdev - Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by removing flowi4_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160615.124800.889153492414820174.davem@davemloft.net>
Date:	Wed, 15 Jun 2016 12:48:00 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	hannes@...essinduktion.org, netdev@...r.kernel.org, ja@....bg
Subject: Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by
 removing flowi4_init_output

From: David Ahern <dsa@...ulusnetworks.com>
Date: Mon, 13 Jun 2016 16:02:53 -0600

> I found this helper to be unhelpful developing the VRF changes. Really
> obfuscates the initialization of the flow struct. Happy to see it go.

The whole point was so that it would actually be easier.

If flow structures only get initialized by 2 or 3 helpers, then when
adding new flow fields you only need to update the helpers.

Since you have to update the helper argument signatures in order to do
this, you would be forced to update all call sites and make sure they
passed in suitable new argument(s).

But if people don't use the helpers, and initialize flow structures
on their own, yeah that defeats the whole mechanism and things will
seem harder and "unhelpful".

I really think this is a step backwards.