[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2c081044-0861-8a84-f4ae-88c60c4ddc67@cumulusnetworks.com>
Date: Wed, 15 Jun 2016 14:29:28 -0600
From: David Ahern <dsa@...ulusnetworks.com>
To: David Miller <davem@...emloft.net>
Cc: hannes@...essinduktion.org, netdev@...r.kernel.org, ja@....bg
Subject: Re: [PATCH RFC 1/3] ipv4: make flow functions more grepable by
removing flowi4_init_output
On 6/15/16 1:48 PM, David Miller wrote:
> But if people don't use the helpers, and initialize flow structures
> on their own, yeah that defeats the whole mechanism and things will
> seem harder and "unhelpful".
That's my point -- the flow struct does not have a consistent
initializer. There have been a number of bug patches over the past year
like 4cfc86f3dae6 to handle uninitialized elements. My suggestion here
is the same as 4cfc86f3dae6 which is to initialize the flow when it is
declared.
Consider the recent change from Hannes for 38b7097b55b6. fl6 can be
initialized when it is declared with a bit of straightforward
refactoring -- icmp6_send has an easy split into 2.
Seems like that is a more robust long term solution considering the
various init use cases.
Powered by blists - more mailing lists