netdev - Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160616163336.GD28432@lunn.ch>
Date:	Thu, 16 Jun 2016 18:33:36 +0200
From:	Andrew Lunn <andrew@...n.ch>
To:	Jeremy Linton <jeremy.linton@....com>
Cc:	netdev@...r.kernel.org, steve.glendinning@...well.net,
	sergei.shtylyov@...entembedded.com
Subject: Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are
 overwritten by 0

On Thu, Jun 16, 2016 at 10:54:30AM -0500, Jeremy Linton wrote:
> By default, mdiobus_alloc() sets the PHY's to polling mode, but a
> pointer size memcpy means that couple IRQs (depending
> on 32-bit or 64-bit kernels) end up being overwritten with
> a value of 0. This means that PHY_POLL is disabled and results
> in unpredictable behavior depending on the PHYs location on the mdio
> bus. Remove that memcpy and the now unused phy_irq member to force
> SMSC911x PHY's into polling mode 100% of the time.
> 
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew