netdev - Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f09e570-11e5-e89f-4aa9-b4f198833636@cogentembedded.com>
Date:	Thu, 16 Jun 2016 21:55:23 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:	steve.glendinning@...well.net, andrew@...n.ch
Subject: Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are
 overwritten by 0

On 06/16/2016 06:54 PM, Jeremy Linton wrote:

> By default, mdiobus_alloc() sets the PHY's to polling mode, but a

    Rather "PHYs".

> pointer size memcpy means that couple IRQs (depending

    Could be more words on this line, it's broken too early, I think.

> on 32-bit or 64-bit kernels) end up being overwritten with
> a value of 0. This means that PHY_POLL is disabled and results
> in unpredictable behavior depending on the PHYs location on the mdio

    Contrariwise, "PHY's" here. And it's MDIO.

> bus. Remove that memcpy and the now unused phy_irq member to force
> SMSC911x PHY's into polling mode 100% of the time.
>
> Signed-off-by: Jeremy Linton <jeremy.linton@....com>

Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

[...]

MBR, Sergei