netdev - Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are overwritten by 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30e23b70-d1d5-444a-ac7c-255ae3a03e1e@cogentembedded.com>
Date:	Thu, 16 Jun 2016 22:53:18 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jeremy Linton <jeremy.linton@....com>, netdev@...r.kernel.org
Cc:	steve.glendinning@...well.net, andrew@...n.ch
Subject: Re: [PATCH 1/2] net: smsc911x: Fix bug where PHY interrupts are
 overwritten by 0

On 06/16/2016 09:55 PM, Sergei Shtylyov wrote:

>> By default, mdiobus_alloc() sets the PHY's to polling mode, but a
>
>    Rather "PHYs".
>
>> pointer size memcpy means that couple IRQs (depending
>
>    Could be more words on this line, it's broken too early, I think.
>
>> on 32-bit or 64-bit kernels) end up being overwritten with
>> a value of 0. This means that PHY_POLL is disabled and results
>> in unpredictable behavior depending on the PHYs location on the mdio
>
>    Contrariwise, "PHY's" here. And it's MDIO.
>
>> bus. Remove that memcpy and the now unused phy_irq member to force
>> SMSC911x PHY's into polling mode 100% of the time.
>>
>> Signed-off-by: Jeremy Linton <jeremy.linton@....com>
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>

    I was going to add the following too but just forgot:

Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")

> [...]

MBR, Sergei