netdev - Re: [PATCH net-next] sctp: change sk state to CLOSED instead of CLOSING in sctp_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160616211322.GW22680@localhost.localdomain>
Date:	Thu, 16 Jun 2016 18:13:22 -0300
From:	marcelo.leitner@...il.com
To:	David Miller <davem@...emloft.net>
Cc:	lucien.xin@...il.com, netdev@...r.kernel.org,
	linux-sctp@...r.kernel.org, vyasevich@...il.com,
	daniel@...earbox.net, xiaolong.ye@...el.com, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] sctp: change sk state to CLOSED instead of
 CLOSING in sctp_sock_migrate

On Thu, Jun 16, 2016 at 02:11:39PM -0700, David Miller wrote:
> From: Xin Long <lucien.xin@...il.com>
> Date: Thu, 16 Jun 2016 01:15:06 +0800
> 
> > Commit d46e416c11c8 ("sctp: sctp should change socket state when
> > shutdown is received") may set sk_state CLOSING in sctp_sock_migrate,
> > but inet_accept doesn't allow the sk_state other than ESTABLISHED/
> > CLOSED for sctp. So we will change sk_state to CLOSED, instead of
> > CLOSING, as actually sk is closed already there.
> > 
> > Fixes: commit d46e416c11c8 ("sctp: sctp should change socket state when shutdown is received")
> > Reported-by: Ye Xiaolong <xiaolong.ye@...el.com>
> > Signed-off-by: Xin Long <lucien.xin@...il.com>
> 
> Applied.

I thought Xin was going to post a version with that tag Fixed, but ok.

Patch is good to me, fwiw.