netdev - Re: [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on RK3288

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160616.141514.2135278107149916159.davem@davemloft.net>
Date:	Thu, 16 Jun 2016 14:15:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	vpalatin@...omium.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	andrew@...n.ch, dianders@...omium.org, peppe.cavallaro@...com,
	heiko@...ech.de, zhengsq@...k-chips.com
Subject: Re: [PATCH v2 0/3] net: stmmac: dwmac-rk: fixes for Wake-on-Lan on
 RK3288

From: Vincent Palatin <vpalatin@...omium.org>
Date: Wed, 15 Jun 2016 11:32:20 -0700

> In order to support Wake-On-Lan when using the RK3288 integrated MAC
> (with an external RGMII PHY), we need to avoid shutting down the regulator
> of the external PHY when the MAC is suspended as it's currently done in the MAC
> platform code.
> As a first step, create independant callbacks for suspend/resume rather than
> re-using exit/init callbacks. So the dwmac platform driver can behave differently
> on suspend where it might skip shutting the PHY and at module unloading.
> Then update the dwmac-rk driver to switch off the PHY regulator only if we are
> not planning to wake up from the LAN.
> Finally add the PMT interrupt to the MAC device tree configuration, so we can
> wake up the core from it when the PHY has received the magic packet.
> 
> Changes since v1:
>   * rename 'powered_down' variable into 'suspended'.
>   * fix the logic recording the PHY suspended state according to Heiko comments.

Series applied to net-next, thanks.