| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 19 Jun 2016 23:06:25 -0700
From: Joe Perches <joe@...ches.com>
To: Kedareswara rao Appana <appana.durga.rao@...inx.com>,
nicolas.ferre@...el.com, punnaia@...inx.com, harinik@...inx.com,
anirudh@...inx.com, michals@...inx.com, appanad@...inx.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] net: macb: Add gmii2rgmii converter support
On Mon, 2016-06-20 at 10:57 +0530, Kedareswara rao Appana wrote:
> This patch adds support for gmii2rgmii converter
> in the macb driver.
[]
> diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c
[]
> @@ -376,6 +389,20 @@ static int macb_mii_probe(struct net_device *dev)
> int phy_irq;
> int ret;
>
> + if (bp->gmii2rgmii_phy_node) {
> + phydev = of_phy_attach(bp->dev,
> + bp->gmii2rgmii_phy_node,
> + 0, 0);
> + if (!phydev) {
> + dev_err(&bp->pdev->dev, "%s: no gmii_to_rgmii found\n",
> + dev->name);
why use dev_err(&bp->pdev->dev, ...) and not netdev_err(dev, ...) ?
Powered by blists - more mailing lists