netdev - Re: [PATCH iproute2] Enable use of extra debugging information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7d1368f-c71e-d2fe-bf79-caa631f4ecc9@cumulusnetworks.com>
Date:	Wed, 22 Jun 2016 10:55:34 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Jakub Sitnicki <jkbs@...hat.com>
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org
Subject: Re: [PATCH iproute2] Enable use of extra debugging information

On 6/22/16 2:36 AM, Jakub Sitnicki wrote:
>> diff --git a/Makefile b/Makefile
>> index 15c81ecfdca3..8e006759079d 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -39,7 +39,11 @@ HOSTCC = gcc
>>  DEFINES += -D_GNU_SOURCE
>>  # Turn on transparent support for LFS
>>  DEFINES += -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE
>> +ifdef DEBUG
>> +CCOPTS = -g
>> +else
>>  CCOPTS = -O2
>> +endif
>>  WFLAGS := -Wall -Wstrict-prototypes  -Wmissing-prototypes
>>  WFLAGS += -Wmissing-declarations -Wold-style-definition -Wformat=2
>
> This implies a change of optimization level to -O0 when building with
> DEBUG set, doesn't it? Was it intentional?

yes it is intentional.


> Perhaps it would be less surprising to explicitly set -O0, if that was
> your intention. Just a thought.
>
> Thanks,
> Jakub
>