netdev - Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f4b685f9-a2ad-d3cc-1204-f457705467df@cogentembedded.com>
Date:	Thu, 23 Jun 2016 16:09:00 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Oliver Hartkopp <socketcan@...tkopp.net>,
	Marc Kleine-Budde <mkl@...gutronix.de>, netdev@...r.kernel.org
Cc:	davem@...emloft.net, linux-can@...r.kernel.org,
	kernel@...gutronix.de, stable@...r.kernel.org
Subject: Re: [PATCH 2/3] can: fix oops caused by wrong rtnl dellink usage

On 6/23/2016 4:01 PM, Oliver Hartkopp wrote:

>>> From: Oliver Hartkopp <socketcan@...tkopp.net>
>>>
>>> For 'real' hardware CAN devices the netlink interface is used to set CAN
>>> specific communication parameters. Real CAN hardware can not be
>>> created nor
>>> removed with the ip tool ...
>>>
>>> This patch adds a private dellink function for the CAN device driver
>>> interface
>>> that does just nothing.
>>>
>>> It's a follow up to commit 993e6f2fd ("can: fix oops caused by wrong rtnl
>>> newlink usage") but for dellink.
>>>
>>> Reported-by: ajneu <ajneu1@...il.com>
>>> Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>
>>> Cc: <stable@...r.kernel.org>
>>> Signed-off-by: Marc Kleine-Budde <mkl@...gutronix.de>
>>> ---
>>>  drivers/net/can/dev.c | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c
>>> index 348dd5001fa4..ad535a854e5c 100644
>>> --- a/drivers/net/can/dev.c
>>> +++ b/drivers/net/can/dev.c
>>> @@ -1011,6 +1011,11 @@ static int can_newlink(struct net *src_net,
>>> struct net_device *dev,
>>>      return -EOPNOTSUPP;
>>>  }
>>>
>>> +static void can_dellink(struct net_device *dev, struct list_head *head)
>>> +{
>>> +    return;
>>
>>    Why?
>>
>
> http://marc.info/?l=linux-can&m=146651600421205&w=2
>
> The same reason as for commit 993e6f2fd.

    I was asking just about the useless *return* statement...

> Regards,
> Oliver

MBR, Sergei