netdev - Re: [PATCH] dsa: mv88e6xxx: hide unused functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160627.104336.460514363808844247.davem@davemloft.net>
Date:	Mon, 27 Jun 2016 10:43:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	vivien.didelot@...oirfairelinux.com
Cc:	arnd@...db.de, andrew@...n.ch, f.fainelli@...il.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dsa: mv88e6xxx: hide unused functions

From: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Date: Thu, 23 Jun 2016 11:21:27 -0400

> Hi,
> 
> Arnd Bergmann <arnd@...db.de> writes:
> 
>> When CONFIG_NET_DSA_HWMON is disabled, we get warnings about two unused
>> functions whose only callers are all inside of an #ifdef:
>>
>> drivers/net/dsa/mv88e6xxx.c:3257:12: 'mv88e6xxx_mdio_page_write' defined but not used [-Werror=unused-function]
>> drivers/net/dsa/mv88e6xxx.c:3244:12: 'mv88e6xxx_mdio_page_read' defined but not used [-Werror=unused-function]
>>
>> This adds another ifdef around the function definitions. The warnings
>> appeared after the functions were marked 'static', but the problem
>> was already there before that.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: 57d3231057e9 ("net: dsa: mv88e6xxx: fix style issues")
> 
> Reviewed-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
> 
> David, this patch is meant for net-next. It applies cleanly *before* my
> last two submissions:
> 
>     1/2 http://patchwork.ozlabs.org/patch/638773/
>     2/2 http://patchwork.ozlabs.org/patch/638772/

Oops, I applied those already.

Arnd, please respin if necessary.