netdev - Re: [PATCH] vsock: make listener child lock ordering explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20160627.104502.1280455139010334440.davem@davemloft.net>
Date:	Mon, 27 Jun 2016 10:45:02 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stefanha@...hat.com
Cc:	netdev@...r.kernel.org, imbrenda@...ux.vnet.ibm.com,
	jhansen@...are.com
Subject: Re: [PATCH] vsock: make listener child lock ordering explicit

From: Stefan Hajnoczi <stefanha@...hat.com>
Date: Thu, 23 Jun 2016 16:28:58 +0100

> There are several places where the listener and pending or accept queue
> child sockets are accessed at the same time.  Lockdep is unhappy that
> two locks from the same class are held.
> 
> Tell lockdep that it is safe and document the lock ordering.
> 
> Originally Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com> sent a similar
> patch asking whether this is safe.  I have audited the code and also
> covered the vsock_pending_work() function.
> 
> Suggested-by: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@...hat.com>

Applied, thanks.