netdev - Re: [PATCH iproute2 1/3] ss: Refactor inet_show

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160627110655.474ef337@xeon-e3>
Date:	Mon, 27 Jun 2016 11:06:55 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 1/3] ss: Refactor inet_show_sock

On Tue, 21 Jun 2016 20:38:24 -0700
David Ahern <dsa@...ulusnetworks.com> wrote:

> Extract parsing of sockstat and filter from inet_show_sock.
> While moving run_ssfilter into callers of inet_show_sock enable
> userspace filtering before the kill.
> 
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

I would add this but it has checkpatch style issues

WARNING: braces {} are not necessary for any arm of this statement
#65: FILE: misc/ss.c:2060:
+	if (s->local.family == AF_INET) {
[...]
 	} else {
[...]

WARNING: line over 80 characters
#80: FILE: misc/ss.c:2070:
+static int inet_show_sock(struct nlmsghdr *nlh, struct sockstat *s, int protocol)

ERROR: do not use assignment in if condition
#129: FILE: misc/ss.c:2295:
+	if ((err = inet_show_sock(h, &s, diag_arg->protocol)) < 0)