netdev - Re: [PATCH iproute2 3/3] ss: Add support to filter on device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160627110921.7ae95e63@xeon-e3>
Date:	Mon, 27 Jun 2016 11:09:21 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David Ahern <dsa@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH iproute2 3/3] ss: Add support to filter on device

On Tue, 21 Jun 2016 20:38:26 -0700
David Ahern <dsa@...ulusnetworks.com> wrote:

> Add support for device names in the filter. Example:
> 
>     root@...ny:~# ss -t  'sport == :22 && dev == red'
>     State      Recv-Q Send-Q     Local Address:Port      Peer Address:Port
>     ESTAB      0      0          10.100.1.2%red:ssh      10.100.1.254:47814
>     ESTAB      0      0           2100:1::2%red:ssh        2100:1::64:49406
> 
> Since kernel does not support iface in the filter specifying a
> device name means all filtering is done in userspace.
> 

Introduces new checkpatch whitespace issues.
ERROR: code indent should use tabs where possible
#60: FILE: misc/ss.c:1337:
+               case SSF_DEVCOND:$

WARNING: please, no spaces at the start of a line
#60: FILE: misc/ss.c:1337:
+               case SSF_DEVCOND:$

ERROR: code indent should use tabs where possible
#63: FILE: misc/ss.c:1340:
+                return 0;$

WARNING: please, no spaces at the start of a line
#63: FILE: misc/ss.c:1340:
+                return 0;$