netdev - Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete csum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca13266f-4cd9-3ac1-9092-9142475cbce9@gmail.com>
Date:	Wed, 29 Jun 2016 17:23:18 +0300
From:	Tariq Toukan <ttoukan.linux@...il.com>
To:	Cong Wang <xiyou.wangcong@...il.com>,
	Or Gerlitz <gerlitz.or@...il.com>
Cc:	Tom Herbert <tom@...bertland.com>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Shani Michaeli <shanim@...lanox.com>,
	Tariq Toukan <tariqt@...lanox.com>,
	Yishai Hadas <yishaih@...lanox.com>,
	Carol L Soto <clsoto@...ibm.com>
Subject: Re: [Patch net] mlx4: set csum_complete_sw bit when fixing complete
 csum

Hi Cong,

> See below. Does commit f8c6455bb04b944edb69e rely on any firmware
> change to get an expected checksum?
>
> $ lspci -nn | grep -i mellanox
> 82:00.0 Ethernet controller [0200]: Mellanox Technologies MT27500
> Family [ConnectX-3] [15b3:1003]
>
> $ ethtool -i eth0
> driver: mlx4_en
> version: 2.2-1 (Feb 2014)
> firmware-version: 2.33.5220
> bus-info: 0000:82:00.0
I used same HW and FW, but was not able to reproduce.
I have kernel HEAD of net-next: 8a79813c1401 net: ethernet: dwc_eth_qos: 
use phy_ethtool_{get|set}_link_ksettings

I ran regular ping, and ping6. Checksum complete counter increases, but 
no warnings in dmesg.
What kernel do you use? Does it repro on latest net-next?