netdev - Re: [PATCH net] net: poll tx timeout only on active tx queues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1467296892.11238.24.camel@edumazet-glaptop3.roam.corp.google.com>
Date:	Thu, 30 Jun 2016 16:28:12 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Saeed Mahameed <saeedm@...lanox.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Eric Dumazet <edumazet@...gle.com>,
	Tom Herbert <tom@...bertland.com>,
	Mohamad Haj Yahia <mohamad@...lanox.com>
Subject: Re: [PATCH net] net: poll tx timeout only on active tx queues

On Thu, 2016-06-30 at 16:58 +0300, Saeed Mahameed wrote:
> From: Mohamad Haj Yahia <mohamad@...lanox.com>
> 
> Change the netdev watchdog to poll only the real active tx queues
> instead of polling all tx queues.
> The netdev driver doesn't necessarily have to start/stop all the
> tx queues including the inactive tx queues.
> 
> Fixes: fd2ea0a79faa ('net: Use queue aware tests throughout.')
> Signed-off-by: Mohamad Haj Yahia <mohamad@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> ---
>  net/sched/sch_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
> index f9e0e9c..a10f0ff 100644
> --- a/net/sched/sch_generic.c
> +++ b/net/sched/sch_generic.c
> @@ -253,7 +253,7 @@ static void dev_watchdog(unsigned long arg)
>  			unsigned int i;
>  			unsigned long trans_start;
>  
> -			for (i = 0; i < dev->num_tx_queues; i++) {
> +			for (i = 0; i < dev->real_num_tx_queues; i++) {
>  				struct netdev_queue *txq;
>  
>  				txq = netdev_get_tx_queue(dev, i);

Strange, why don't you change all others helpers that are using
num_tx_queues ?

Which driver had a problem with this code ?