netdev - Re: [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160630151510.GA20137@hari-Latitude-E5550>
Date:	Thu, 30 Jun 2016 20:45:11 +0530
From:	Hariprasad Shenai <hariprasad@...lsio.com>
To:	Yuval Mintz <Yuval.Mintz@...gic.com>
Cc:	David Miller <davem@...emloft.net>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	netdev <netdev@...r.kernel.org>,
	"leedom@...lsio.com" <leedom@...lsio.com>,
	"nirranjan@...lsio.com" <nirranjan@...lsio.com>,
	"kumaras@...lsio.com" <kumaras@...lsio.com>
Subject: Re: [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address
 support

On Thu, Jun 30, 2016 at 13:13:15 +0000, Yuval Mintz wrote:
> > +	/* verify MAC addr is valid */
> > +	if (!is_zero_ether_addr(mac) && !is_valid_ether_addr(mac) &&
> > +	    is_multicast_ether_addr(mac)) {
> 
> This is really odd as verification goes; Currently this is a very elaborate
> way of checking for multicast, but I guess it's  probably a mistake.
> 
My bad, will send a V2