lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 30 Jun 2016 13:13:15 +0000
From:	Yuval Mintz <Yuval.Mintz@...gic.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>,
	David Miller <davem@...emloft.net>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>
CC:	netdev <netdev@...r.kernel.org>,
	"leedom@...lsio.com" <leedom@...lsio.com>,
	"nirranjan@...lsio.com" <nirranjan@...lsio.com>,
	"kumaras@...lsio.com" <kumaras@...lsio.com>
Subject: RE: [PATCH net-next 2/3] cxgb4/cxgb4vf: Add set VF mac address
 support

> +	/* verify MAC addr is valid */
> +	if (!is_zero_ether_addr(mac) && !is_valid_ether_addr(mac) &&
> +	    is_multicast_ether_addr(mac)) {

This is really odd as verification goes; Currently this is a very elaborate
way of checking for multicast, but I guess it's  probably a mistake.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ